-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework of the Python Filter (Depends on PR Support UDP TCP #224) #232
Draft
ThibaudCartegnie
wants to merge
17
commits into
support_tcp_udp
Choose a base branch
from
python_filter
base: support_tcp_udp
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frikilax
reviewed
Feb 4, 2022
} | ||
} | ||
for(auto cert: resp.certitudes) { | ||
_packet.AddCertitude(cert); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stats' support might be complicated with this filter, bu I think you could add a STAT_MATCH_INC;
for each certitude over threshold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it
example.py is made a better example to test the filter Added logger to example added support for venv updated cmake min version
- now expects a class (see algorithm_module.py) - added tests for class specific issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request Template
📃 Type of change
Please delete options that are not relevant.
Breaking change: fix or feature that would cause existing functionality to not work as expected.
💡 Related Issue(s)
✒️ Description
Reworks the python filter to be closer of what we need and easier to use.
🎯 Test Environments
FreeBSD - Vulture ISO (12.2)
Ubuntu (20.04)
✔️ Checklist: