Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FHOSTLOOKUP:: FIX ABSENT FEED_NAME IN CASE OF NON-TEXT DB #202

Merged
merged 2 commits into from
Sep 17, 2020

Conversation

frikilax
Copy link
Member

@frikilax frikilax commented Sep 11, 2020

✨ FHOSTLOOKUP:: FIX ABSENT FEED_NAME IN CASE OF NON-TEXT DB

‼️ Once all the checklist is done you have to:

  • stash merge this pull request
  • delete the corresponding branch
  • close the associated issue

📃 Type of change

Please delete options that are not relevant.

Bug fix: non-breaking change which fixes an issue.

💡 Related Issue(s)

✒️ Description

Fixes the absence of feed name when the hostlookup filter uses a "json" or "rsyslog" type database.

🎯 Test Environments

HBSD (12.1)

  • clang++ 10.0.0
  • CMake 3.17.3
  • Python 3.7

Ubuntu (18.04)

  • g++ 7.5.0
  • CMake 3.10.2
  • Python 3.6
  • Valgrind 3.13.0

✔️ Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

  • 🙋 I certify on my honor that all the information provided is true, and I've done all I can to deliver a high quality code

@frikilax frikilax added the bug Something isn't working label Sep 11, 2020
@frikilax frikilax self-assigned this Sep 11, 2020
@frikilax frikilax linked an issue Sep 11, 2020 that may be closed by this pull request
@frikilax frikilax merged commit 85d1e64 into dev Sep 17, 2020
@frikilax frikilax deleted the fix_hostlookup branch September 17, 2020 09:01
@frikilax frikilax added this to the 1.4.0 milestone Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Hostlookup feed name is recovered only from text db types
2 participants