Harmonize date format #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2020 13:49
From now on, all date formats il logs and alerts should be the same (UTC timezone with RFC 3339) Changes were applied in: manager.py for manager's logs Logger.cpp for filters' logs No needs to change for: alerting
Just removed useless statements due to modifications as well as comments and debug prints.
HugoSoszynski
previously approved these changes
Sep 17, 2020
frikilax
requested changes
Sep 17, 2020
manager/manager.py
Outdated
Comment on lines
86
to
89
| date = datetime.utcnow().isoformat('T').split('.')[0] + 'Z' | ||
|
|
||
| formatter = logging.Formatter( | ||
| '{"date":"%(asctime)s","level":"%(levelname)s","message":"%(message)s"}') | ||
| '{"date":"' + date + '","level":"%(levelname)s","message":"%(message)s"}') |
There was a problem hiding this comment.
date will always be the same, can't do it this way
Applied a converter to log in UTC. Applied the following date format: %Y-%m-%dT%H:%M:%SZ
frikilax
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request Template
📃 Type of change
Bug fix: non-breaking change which fixes an issue.
💡 Related Issue(s)
✒️ Description
We used to have several different date formats, which are now harmonized in UTC / RFC 3339.
🎯 Test Environments
HBSD 12.1
Ubuntu 20.04
✔️ Checklist: