Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] format of filter logs' date is not RFC3339 #200

Closed
frikilax opened this issue Sep 8, 2020 · 0 comments · Fixed by #203
Closed

[BUG] format of filter logs' date is not RFC3339 #200

frikilax opened this issue Sep 8, 2020 · 0 comments · Fixed by #203
Assignees
Labels
bug Something isn't working good first issue Good for newcomers intermediate
Milestone

Comments

@frikilax
Copy link
Member

frikilax commented Sep 8, 2020

Describe the bug
Darwin should be consistent when using date formats in alerts, manager and filters' logs .
However, this is currently not the case:

  • date format in manager logs : 2020-07-22 13:22:53,750 (not correct)
  • date format in filters logs: Fri Jun 5 15:00:01 2020 (not correct)
  • date format in alerting: 2020-09-07T11:58:35Z

Plateform (please complete the following information):

  • OS (version): Ubuntu 18.04/HBSD12-STABLE
  • Darwin version: 1.3.1

To Reproduce
Steps to reproduce the behavior:

  1. Change manager configuration to DEBUG (in service file)
  2. Setup a darwin configuration with at least a filter in DEBUG
  3. Start darwin and ensure filter is started
  4. check darwin_manager.log and darwin.log
  5. formats should be different

Expected behavior
All date formats should be consistent between sources, adn preferably valid and consistent RFC3339 (%Y%Y%Y%Y-%M%M-%D%DT%h%h:%m%m:%s%sZ)

Screenshots/logs
date log format for darwin.log (filters' logs):
image

date log format for darwin_manager.log (manager's logs):
image

(preferred) date log format for alerts.Log:
image

@frikilax frikilax added bug Something isn't working good first issue Good for newcomers intermediate labels Sep 8, 2020
@GregoireGonzalez GregoireGonzalez self-assigned this Sep 17, 2020
@frikilax frikilax added this to the 1.4.0 milestone Sep 21, 2020
@frikilax frikilax linked a pull request Sep 21, 2020 that will close this issue
6 tasks
HugoSoszynski pushed a commit that referenced this issue Sep 22, 2020
# ✨ Pull Request Template
‼️ Once all the **checklist** is **done** you have to:
  * **stash merge** this pull request
  * **delete** the corresponding **branch**
  * **close** the associated **issue**

## 📃 Type of change

**Bug fix**: non-breaking change which fixes an issue.

## 💡 Related Issue(s)

- Resolve #200

## ✒️ Description

We used to have several different date formats, which are now harmonized in UTC / RFC 3339.

## 🎯 Test Environments

### HBSD  12.1
- Redis 5.0.9
- Boost 1.72
- clang++ 10.0.0
- CMake 3.17.3
- Python 3.7

### Ubuntu 20.04
- Redis 5.0.9
- Boost 1.72
- GCC 9.3.0
- CMake 3.16.3
- Python 3.8

## ✔️ Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation (no changes needed)
- [x] New and existing unit tests pass locally with my changes

</br>

- [x] 🙋 **I certify on my honor that all the information provided is true, and I've done all I can to deliver a high quality code**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers intermediate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants