Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/async mock on py38 and asyncio.run on py36 #21

Merged
merged 8 commits into from
Nov 22, 2020
Merged

Fix/async mock on py38 and asyncio.run on py36 #21

merged 8 commits into from
Nov 22, 2020

Conversation

Voyz
Copy link
Owner

@Voyz Voyz commented Nov 21, 2020

Fixes #9

  • switches from asyncmock's CoroutineMock to unittest.mock AsyncMock when on Python 3.8
  • monkey patches asyncio.run on Python 3.6 - this should introduce support for Python 3.6
  • cleaned up some tests syntax to use MagicMock instead of mock.MagicMock, etc.

@Voyz Voyz added bug Something isn't working enhancement New feature or request labels Nov 21, 2020
@Voyz Voyz requested a review from cdpierse November 21, 2020 10:28
@cdpierse cdpierse mentioned this pull request Nov 21, 2020
Merged
cdpierse
cdpierse approved these changes Nov 21, 2020
View reviewed changes
Copy link
Collaborator

@cdpierse cdpierse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice job with monkey patching in support for Asyncio on 3.6!

@Voyz
Copy link
Owner Author

Voyz commented Nov 22, 2020

Cheers, thanks for the review! :)

@Voyz Voyz merged commit a43036f into dev Nov 22, 2020
@Voyz Voyz deleted the fix/async-mock-on-py38 branch November 22, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdpierse cdpierse cdpierse approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Voyz @cdpierse