Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network API: SIM Swap and Number Verification implementation #313

Merged

Conversation

superchilled
Copy link
Contributor

@superchilled superchilled commented Jul 30, 2024

This PR implements the Network Number Verification API and Network SIM Swap API into the Ruby SDK. Specifically it:

  • Defines a new authentication class, NetworkAuthentication to provide an abstract interface for the specific OAuth flows used by the endpoints.
  • Defines specific NetworkAuthentication::ClientAuthentication and NetworkAuthentication::ServerAuthentication classes to support client and server initiated OAuth flows.
  • Updates the Namespace class to support these new authentication flows
  • Updates other authentication classes to work in line with high-level authentication changes in the updated Namespace class
  • Implements a NetworkNumberVerification class with the following methods:
    • verify
    • generate_oidc_uri
  • Implements a NetworkSIMSwap class with the following methods:
    • check
    • retrieve_date
  • Udpates the Client class to add accessors for NetworkNumberVerification and NetworkSIMSwap
  • Adds unit, and some integration, tests for all of the above functionality.

@superchilled superchilled marked this pull request as ready for review August 7, 2024 16:25
@superchilled superchilled merged commit 9327396 into main Aug 8, 2024
14 checks passed
@superchilled superchilled deleted the devx-8424-devx-8419-network-sim-swap-number-verification branch August 8, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant