Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching HTTP adapter #304

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Switching HTTP adapter #304

merged 3 commits into from
Feb 21, 2024

Conversation

superchilled
Copy link
Contributor

@superchilled superchilled commented Feb 21, 2024

This PR:

  • Changes the HTTP adapter from Net::HTTP to Net::HTTP::Persistent
  • Fixes an issue with a dependency (ruby-jwt)

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16e948f) 98.06% compared to head (5da98e5) 98.06%.

❗ Current head 5da98e5 differs from pull request most recent head 052f1fa. Consider uploading reports for the commit 052f1fa to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         119      119           
  Lines        2170     2170           
=======================================
  Hits         2128     2128           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superchilled superchilled marked this pull request as ready for review February 21, 2024 10:40
@superchilled superchilled merged commit 7bfc223 into main Feb 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants