-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVX-6851: Add Meetings API #258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert "Add Patch HTTP method as option for http_request in JSON.update type signature" * Revert "Release 7.7.1" * Revert "Revert "Add Patch HTTP method as option for http_request in JSON.update type signature"" * Revert "Revert "Release 7.7.1"" * Adding WhatsApp sticker tests * Implementing WhatsApp Sticker messages * Adding new Viber message types * Defining Verify2 class and stubbing methods * Adding initial Verify2 tests * Adding initial Verify2 implementation * Making brand a required param of start_verfication * Adding verify2 client test * Implementing CLient#verify2 method * Adding Verify2::Options tests * Renaming Verify2::Options class to StartVerificationOptions * Renaming options test file in line with Zeitwerk conventions * Fixing typo in Verify2#start_verification method name * Fixing typo in Verify2 options test filename * Fixing all the method name typos * Implementing Verify2::StartVerificationOptions class * Adding Verify2 workflow tests * Implementing Verify2 workflow classes * Adding workflow tests * Implementing Workflow class * Adding WorkflowBuilder tests * Implement WorkflowBuilder * Adding tests for Verify2 options, workflow, and workflow_builder methods * Implementing Verify2 options, workflow, and workflow_builder methods * Renaming Workflows to Channels * Updating README to add Verify2 * Adding code comments for Verify2 methods * Updating Numbers to use Basic auth * Updating NumbersTest tests in line with Basic auth usage * Update changelog * Bump version * Update link to code snippets in README.md The old link is archived and points to the updated link. * DEVX-7298: add tests for cancel verification * DEVX-7298: implementing cancel verification method * DEVX-7205: adding tests for BYOP functionality * DEVX-7205: Implementing BYOP functionality * DEVX-7199: Adding tests for fraud check functionality * DEVX-7199: implementing fraud check functionality * DEVX-7199: constraining fraud_check to false * Adding cancel_verification_request to README * Updating changelog * Bumping minor version * DEVX-7008: removing Pay action and tests * DEVX-7175: Updating Talk#start code comments * DEVX-7175: Adding test for Talk#verify_premium method * DEVX-7175: Implementing Talk#verify_premium method * DEVX-7288: updating code comments for Voice#create * DEVX-7288: Adding advanced_machine_detection tests * Implementing advanced_machine_detection functionality * Bump version * Update changelog * Creating file structure and stubbing out methods * Adding Client test * Implementing Client#subaccounts method * Adding Subaccounts tests * Updating Subaccounts tests * Implementing find method * Implementing create method * Implementing update method * Implementing transfer_credity method * IMplementing transfer_balance method * IMplementing transfer_number method * IMplementing list_credit_transfers method * Implementing list_balance_transfers method * IMplementing list method * Fixing host setting * Updating some required fields * Adding code comments for subaccounts methods * Making post-review amendments * Bumping minor version * Updating changelog * Release 7.13.0 (#279) * Adding client test for ProactiveConnect * Implementing Client#proactive_connect * Adding ProactiveConnect tests * Defining proactive connect classes * Implementing ProactiveConnect methods * Adding ProactiveConnect::Lists tests * IMplementing ProactiveConnect::Lists * Adding List tests * Implementing List methods * Adding Items tests for list method * Implementing Items#list method * Adding Item tests * Implementing Item methods * Adding Events tests * Implementing Events methods * Adding item csv tests * Implementing csv lists methods * Updating mulipart_post_request method * Fixes and tidy up * Deleting test_webhooks_method * items_test fix for Windows (maybe?) * Removing test as chmod doesn't work on Windows * Adding docs comments * Updating DEFAULT_FILENAME following PR review * Updating default filename test * Bumping minor version * Updating changelog --------- Co-authored-by: Raphael Nestler <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #258 +/- ##
==========================================
+ Coverage 97.82% 97.94% +0.11%
==========================================
Files 94 105 +11
Lines 1796 1944 +148
==========================================
+ Hits 1757 1904 +147
- Misses 39 40 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality for the Meetings API to the SDK. Specifically, it does the following:
Client
class to add ameetings
method which returns aMeetings
objectMeetings
class with the following methods:rooms
(returns aMeetings::Rooms
object)recordings
(returns aMeetings::Recordings
object)sessions
(returns aMeetings::Sessions
object)themes
(returns aMeetings::Themes
object)applications
(returns aMeetings::Applications
object)dial_in_numbers
(returns aMeetings::DialInNumbers
object)Meetings::Rooms
class with the following methods:list
info
create
update
Meetings::Recordings
class with the following methods:info
delete
Meetings::Sessions
class with the following methods:list_recordings
Meetings::Themes
class with the following methods:list
info
create
update
delete
list_rooms
set_logo
Meetings::Applications
class with the following methods:update
Meetings::DialInNumbers
class with the following methods:list