Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added user-to-user headers for sip endpoint #965

Merged
merged 1 commit into from
Oct 8, 2024
Merged

feat: added user-to-user headers for sip endpoint #965

merged 1 commit into from
Oct 8, 2024

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Oct 8, 2024 •
edited
Loading

This adds missing headers for the SIP endpoint, along with adding the Ethiopia German to language enum

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck
feat: added user-to-user headers for sip endpoint
cc55b5d 
Added Ethiopia German to language enum
@manchuck manchuck marked this pull request as ready for review October 8, 2024 13:06
SMadani
SMadani approved these changes Oct 8, 2024
View reviewed changes
Copy link

@SMadani SMadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume it will also work for the NCCO?

@manchuck
Copy link
Contributor Author

manchuck commented Oct 8, 2024

@SMadani Indeed, since NCCO is sent as a separate property

@manchuck manchuck merged commit 643dfe3 into 3.x Oct 8, 2024
10 of 11 checks passed
@manchuck manchuck deleted the voice-sip-headers branch October 8, 2024 18:10
manchuck added a commit that referenced this pull request Oct 8, 2024
@manchuck
feat: added user-to-user headers for sip endpoint (#965)
6735024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMadani SMadani SMadani approved these changes

@dragonmantank dragonmantank Awaiting requested review from dragonmantank

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manchuck @SMadani