Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New passwordhash package, random and encrypt functions #237

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

nicolaasuni-vonage
Copy link
Collaborator

@nicolaasuni-vonage nicolaasuni-vonage commented Apr 23, 2024

Description

  • New passwordhash package to create and verify a password hash using a strong one-way hashing algorithm. It supports "peppering" by encrypting the hashed passwords using a secret key. It is based on the Argon2id algorithm as recommended by the OWASP Password Storage Cheat Sheet: https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html
  • New typeutil encryption functions with JSON serialization.
  • New utility random functions.

Checklist:

  • The make x command has been run successfully without any error or warning.
  • Any new code line is covered by unit tests and the coverage has not dropped.
  • Any new code follows the style guidelines of this project.
  • The code changes have been self-reviewed.
  • Corresponding changes to the documentation have been made.
  • The version has been updated in the VERSION and examples/service/go.mod files.

Type of change:

  • Minor non-breaking change (e.g., bug fix, dependencies updates) → The patch number in the VERSION file has been increased.
  • New feature (non-breaking change which adds functionality) → The minor number in the VERSION file has been increased.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) → This requires a major version release.
  • Dependencies.
  • Automation.
  • Documentation.
  • Examples.
  • Testing.

@nicolaasuni-vonage nicolaasuni-vonage requested review from a team as code owners April 23, 2024 12:44
Copy link
Collaborator Author

@nicolaasuni-vonage nicolaasuni-vonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Apr 23, 2024

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8800622311

Details

  • 163 of 163 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8785471487: 0.0%
Covered Lines: 5688
Relevant Lines: 5688

💛 - Coveralls

@nicolaasuni-vonage nicolaasuni-vonage merged commit dcf43be into main Apr 23, 2024
12 checks passed
@nicolaasuni-vonage nicolaasuni-vonage deleted the passhash branch April 23, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants