Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New encoding/decoding options for sqs, kafka and kafacgo #235

Merged
merged 9 commits into from
Apr 18, 2024

Conversation

nicolaasuni-vonage
Copy link
Collaborator

@nicolaasuni-vonage nicolaasuni-vonage commented Apr 17, 2024

Description

  • Ability to specify custom sqs.SendData encoding and sqs.ReceiveData decoding functions.
  • Added SendData and ReceiveData methods in kafka and kafkacgo with the options to specify custom encoding and decoding functions.
  • New Encrypt and Decrypt utility functions based on AES-GCM.

Checklist:

  • The make x command has been run successfully without any error or warning.
  • Any new code line is covered by unit tests and the coverage has not dropped.
  • Any new code follows the style guidelines of this project.
  • The code changes have been self-reviewed.
  • Corresponding changes to the documentation have been made.
  • The version has been updated in the VERSION and examples/service/go.mod files.

Type of change:

  • Minor non-breaking change (e.g., bug fix, dependencies updates) → The patch number in the VERSION file has been increased.
  • New feature (non-breaking change which adds functionality) → The minor number in the VERSION file has been increased.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) → This requires a major version release.
  • Dependencies.
  • Automation.
  • Documentation.
  • Examples.
  • Testing.

@nicolaasuni-vonage nicolaasuni-vonage requested review from a team as code owners April 17, 2024 14:39
Copy link
Collaborator Author

@nicolaasuni-vonage nicolaasuni-vonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Apr 17, 2024

Pull Request Test Coverage Report for Build 8733262800

Details

  • 172 of 172 (100.0%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8706927471: 0.0%
Covered Lines: 5519
Relevant Lines: 5519

💛 - Coveralls

Copy link

sonarcloud bot commented Apr 18, 2024

@nicolaasuni-vonage nicolaasuni-vonage merged commit 6dc8f50 into main Apr 18, 2024
12 checks passed
@nicolaasuni-vonage nicolaasuni-vonage deleted the queueenc branch April 18, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants