Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New linter rules #210

Merged
merged 9 commits into from
Sep 14, 2023
Merged

New linter rules #210

merged 9 commits into from
Sep 14, 2023

Conversation

nicolaasuni-vonage
Copy link
Collaborator

@nicolaasuni-vonage nicolaasuni-vonage commented Sep 14, 2023

Description

Enabled new golangci-linter rules and adjusted the code accordingly.
A lot of files were changed but most changes are just aesthetically.
Each new rule with code-related changes has been pushed in a separate commit.
All existing tests are passing unaltered.

Checklist:

  • The make x command has been run successfully without any error or warning.
  • Any new code line is covered by unit tests and the coverage has not dropped.
  • Any new code follows the style guidelines of this project.
  • The code changes have been self-reviewed.
  • Corresponding changes to the documentation have been made.
  • The version has been updated in the VERSION and examples/service/go.mod files.

Type of change:

  • Bug fix (non-breaking change which fixes an issue) → The patch number in the VERSION file has been increased.

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@nicolaasuni-vonage nicolaasuni-vonage merged commit d7e1d12 into main Sep 14, 2023
13 checks passed
@nicolaasuni-vonage nicolaasuni-vonage deleted the linter_20230914 branch September 14, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants