Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new lines in Text Area and Code Editor #563

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

vitPinchuk
Copy link
Contributor

await : Packages

Resolves: #557

@vitPinchuk vitPinchuk self-assigned this Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (6e99bf8) to head (a96f32a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         119      119           
  Lines        2099     2102    +3     
  Branches      512      539   +27     
=======================================
+ Hits         2080     2083    +3     
  Misses         17       17           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 29, 2024
@mikhail-vl mikhail-vl added this to the Forms 5.0.0 milestone Nov 29, 2024
@vitPinchuk vitPinchuk marked this pull request as ready for review December 2, 2024 07:25
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@mikhail-vl mikhail-vl changed the title Verify new lines Text Area and Code Editor Update new lines in Text Area and Code Editor Dec 9, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 4471ba8 into main Dec 9, 2024
5 checks passed
@mikhail-vl mikhail-vl deleted the feat/new-lines-issue-text-area-code-editor branch December 9, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Verify new lines in text area for Windows users
3 participants