Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Share Extension #31

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cedricbahirwe
Copy link

Hey @VishwaiOSDev , Thanks for building this amazing app!

This PR introduces a share extension feature to the app, enabling users to share links from various sources directly to the app. The share extension enhances user convenience by allowing seamless access to the app's functionality for downloading video content related to shared URLs.

Changes Made

  • Added a share extension to the iOS app, facilitating URL sharing from other apps or sources.
  • Designed and implemented a custom UI for the share extension, providing a streamlined user experience.
  • Implemented URL validation within the share extension to ensure only valid URLs are processed.
  • Managed redirection to the main app using custom URL schemes, passing the URL for content download.
  • Ensured accessibility of necessary files and components to the share extension by adding them to its target Xcode membership.

Challenges Faced

No significant challenges were encountered during the implementation process. However, a consideration for future enhancements would be implementing stronger validation to support only specific target URL platforms, such as YouTube and Instagram for now.

Testing

  1. Share a URL from any supported source using the share sheet (especially from YouTube or Instagram app).
  2. Verify that the share extension activates and displays the custom UI.
  3. Ensure that only valid URLs are processed by the extension.
  4. Validate the redirection to the main app and the passing of the URL for content download.

@cedricbahirwe cedricbahirwe changed the title ImplementShare Extension for iOS App Implement Share Extension Mar 23, 2024
@VishwaiOSDev
Copy link
Owner

Hey @cedricbahirwe, I wanted to express my sincere gratitude for your recent contribution to Loadify by implementing the share extension feature. Your effort is greatly appreciated. During my testing of the share extension, I encountered a few crashes related to the ChannelView when loading up the image. Upon reviewing the code, I realized that I had mistakenly used force unwrapping for the image URL, which is not the best practice.

Screenshot 2024-03-23 at 3 52 22 PM

I want to assure you that I'm taking responsibility for these errors and will promptly rectify them. I'll make the necessary changes to the codebase and continue testing the share extension to ensure its smooth functionality. Rest assured, your valuable contribution will be merged into the project within the next couple of days.

Once again, I want to extend my heartfelt thanks for your time, dedication, and collaboration on Loadify. Your support is invaluable to the success of our project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants