Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update actions, minor fixes #87

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Conversation

kbdharun
Copy link
Contributor

@kbdharun kbdharun commented Dec 7, 2023

Changes

  • Bump actions/checkout from v3 (Node 16) to v4 (Node 20).
  • Bump actions/setup-go from v4 to v5 (Node 20) [This release also comes with some improvements to caching between builds].
  • Set default end of line (eol) to LF (this would prevent conversion to CRLF when making PRs from Windows) in the new .gitattributes file.
  • Fix spacing between codeblocks and other elements (It is generally good practice to have a line of space between the contents and the codeblock itself).

README.md Outdated
Comment on lines 111 to 121
Make sure the `bash-completion` package is installed (Cygwin doesn't installed it by default) and type:
```sh
$ vt completion bash > /usr/share/bash-completion/completions/vt
```
Make sure the `bash-completion` package is installed (Cygwin doesn't installed it by default) and type:

```sh
$ vt completion bash > /usr/share/bash-completion/completions/vt
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks the formatting of our readme. Revert it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, fixed it. Made some minor modifications too, feel free to let me know if I need to revert anything.

Copy link
Member

@mgmacias95 mgmacias95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@mgmacias95 mgmacias95 merged commit 3712a1b into VirusTotal:master Jan 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants