Skip to content

Directives API #3639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import scala.build.options.{
SuppressWarningOptions,
WithBuildRequirements
}
import scala.build.preprocessing.directives.DirectivesPreprocessingUtils.*
import scala.build.preprocessing.directives.Directives.*
import scala.build.preprocessing.directives.PartiallyProcessedDirectives.*
import scala.build.preprocessing.directives.*

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ import scala.collection.immutable.HashMap
import scala.util.chaining.scalaUtilChainingOps

object BuiltInRules extends CommandHelpers {
private lazy val targetDirectivesKeysSet = DirectivesPreprocessingUtils.requireDirectiveHandlers
private lazy val targetDirectivesKeysSet = Directives.requireDirectiveHandlers
.flatMap(_.keys.flatMap(_.nameAliases)).toSet
private lazy val usingDirectivesKeysGrouped = DirectivesPreprocessingUtils.usingDirectiveHandlers
private lazy val usingDirectivesKeysGrouped = Directives.usingDirectiveHandlers
.flatMap(_.keys)
private lazy val usingDirectivesWithTestPrefixKeysGrouped =
DirectivesPreprocessingUtils.usingDirectiveWithReqsHandlers
Directives.usingDirectiveWithReqsHandlers
.flatMap(_.keys)

private lazy val directiveTestPrefix = "test."
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,35 +46,41 @@ trait DirectiveHandler[+T] { self =>

def map[U](f: T => U): DirectiveHandler[U] =
new DirectiveHandler[U] {
def name = self.name
def usage = self.usage
override def usageMd = self.usageMd
def description = self.description
override def descriptionMd = self.descriptionMd
override def examples = self.examples
def name: String = self.name
def usage: String = self.usage
override def usageMd: String = self.usageMd
def description: String = self.description
override def descriptionMd: String = self.descriptionMd
override def examples: Seq[String] = self.examples

def scalaSpecificationLevel = self.scalaSpecificationLevel
def scalaSpecificationLevel: SpecificationLevel = self.scalaSpecificationLevel

def keys = self.keys
def keys: Seq[Key] = self.keys

def handleValues(scopedDirective: ScopedDirective, logger: Logger) =
def handleValues(
scopedDirective: ScopedDirective,
logger: Logger
): Either[BuildException, ProcessedDirective[U]] =
self.handleValues(scopedDirective, logger)
.map(_.map(f))
}
def mapE[U](f: T => Either[BuildException, U]): DirectiveHandler[U] =
new DirectiveHandler[U] {
def name = self.name
def usage = self.usage
override def usageMd = self.usageMd
def description = self.description
override def descriptionMd = self.descriptionMd
override def examples = self.examples
def name: String = self.name
def usage: String = self.usage
override def usageMd: String = self.usageMd
def description: String = self.description
override def descriptionMd: String = self.descriptionMd
override def examples: Seq[String] = self.examples

def scalaSpecificationLevel = self.scalaSpecificationLevel
def scalaSpecificationLevel: SpecificationLevel = self.scalaSpecificationLevel

def keys = self.keys
def keys: Seq[Key] = self.keys

def handleValues(scopedDirective: ScopedDirective, logger: Logger) =
def handleValues(
scopedDirective: ScopedDirective,
logger: Logger
): Either[BuildException, ProcessedDirective[U]] =
self.handleValues(scopedDirective, logger).flatMap(_.mapE(f))
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,12 @@ import scala.build.directives.{
HasBuildOptionsWithRequirements,
HasBuildRequirements
}
import scala.build.errors.{BuildException, UnusedDirectiveError}
import scala.build.options.{BuildOptions, BuildRequirements, WithBuildRequirements}
import scala.build.preprocessing.directives

object DirectivesPreprocessingUtils {
object Directives {
val usingDirectiveHandlers: Seq[DirectiveHandler[BuildOptions]] =
Seq[DirectiveHandler[_ <: HasBuildOptions]](
Seq[DirectiveHandler[? <: HasBuildOptions]](
directives.Benchmarking.handler,
directives.BuildInfo.handler,
directives.ComputeVersion.handler,
Expand All @@ -37,7 +36,7 @@ object DirectivesPreprocessingUtils {

val usingDirectiveWithReqsHandlers
: Seq[DirectiveHandler[List[WithBuildRequirements[BuildOptions]]]] =
Seq[DirectiveHandler[_ <: HasBuildOptionsWithRequirements]](
Seq[DirectiveHandler[? <: HasBuildOptionsWithRequirements]](
directives.CustomJar.handler,
directives.Dependency.handler,
directives.JavaOptions.handler,
Expand All @@ -49,10 +48,17 @@ object DirectivesPreprocessingUtils {
).map(_.mapE(_.buildOptionsWithRequirements))

val requireDirectiveHandlers: Seq[DirectiveHandler[BuildRequirements]] =
Seq[DirectiveHandler[_ <: HasBuildRequirements]](
Seq[DirectiveHandler[? <: HasBuildRequirements]](
directives.RequirePlatform.handler,
directives.RequireScalaVersion.handler,
directives.RequireScalaVersionBounds.handler,
directives.RequireScope.handler
).map(_.mapE(_.buildRequirements))

def allDirectiveHandlers: Seq[DirectiveHandler[BuildRequirements | BuildOptions]] =
usingDirectiveHandlers ++ requireDirectiveHandlers

def getDirectiveHandler(key: String): Option[DirectiveHandler[BuildRequirements | BuildOptions]] =
allDirectiveHandlers.find(_.keys.exists(_.nameAliases.contains(key)))

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package scala.build.preprocessing.directives

import com.eed3si9n.expecty.Expecty.expect

class DirectivesTest extends munit.FunSuite {
test("get directive handler by key") {
val key = "python"
val handler = Directives.getDirectiveHandler(key).get
expect(handler.keys.flatMap(_.nameAliases).contains(key))
expect(handler.isExperimental)
expect(handler.name == "Python")
expect(handler.description.nonEmpty)
expect(handler.descriptionMd.nonEmpty)
expect(handler.usage.nonEmpty)
expect(handler.usageMd.nonEmpty)
expect(handler.examples.nonEmpty)
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import scala.build.internal.Constants
import scala.build.internals.EnvVar
import scala.build.options.{BuildOptions, BuildRequirements, WithBuildRequirements}
import scala.build.preprocessing.directives.DirectiveHandler
import scala.build.preprocessing.directives.DirectivesPreprocessingUtils.*
import scala.build.preprocessing.directives.Directives.*
import scala.cli.commands.{ScalaCommand, SpecificationLevel, tags}
import scala.cli.doc.ReferenceDocUtils.*
import scala.cli.util.ArgHelpers.*
Expand Down