Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init A4x16 prefab #604

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

another-rishi
Copy link

Hi @dbirman,

I created this pull request to facilitate a few questions about adding this new probe.

So far, I've made my prefab and linked the required scripts using the Neuropixels 4-shank probe as an example.

I've added a button for this prefab to the NewProbePanel prefab, but it does not load my prefab when I click it in a build. Is there some other code I need to edit there to test the new probe prefab?

Also, please note that I have not yet made or built the required channel map files. Could that be breaking the new functionality in my build?

Best and thanks for your input,
Rishi

@another-rishi another-rishi marked this pull request as draft December 12, 2023 16:45
@another-rishi
Copy link
Author

@dbirman,

I'm a bit stuck on debugging this prefab.

I believe I have now added all the required scripts which are linked to the right components and built the channel map. However, when I click the new button in the NewProbePanel, nothing happens.

I don't see anything obvious to edit in the AddProbePanel.cs script, and I'm not quite sure where to look to link this new button to the new probe prefab.

Any help would be greatly appreciated.

Best,
Rishi

@dbirman
Copy link
Member

dbirman commented Jan 4, 2024

@another-rishi I've been on vacation the last month, I'll take a look at this as soon as I'm back next week

@dbirman
Copy link
Member

dbirman commented Jan 9, 2024

Okay I started taking a look here and it looks like a few things went wrong, one is that the AddressableAssets folder seems to have been un-marked as Addressable? That shouldn't happen, can you try re-downloading the google drive folder and replacing it? Be careful to put it at Assets/AddressableAssets (not Assets/AddressableAssets/AddressableAssets where I noticed a duplicate ended up)

The other thing you were missing is a little less obvious, but the buttons for new probes have a UnityEvent that has to be bound to the TrajectoryPlannerManager.AddNewProbeVoid(int) function, this is what actually triggers the probe to be created. You can't bind this in the Prefab because you can't see the main object, it has to be done in the main scene itself.

image

With those two fixes we should be able to get this working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants