VCST-2785: load Serilog configuration after module initialize (#2893)

VirtoCommerce · Feb 25, 2025 · 6edbd97 · 6edbd97
1 parent b7606e8
commit 6edbd97
Showing 1 changed file with 20 additions and 16 deletions.
diff --git a/src/VirtoCommerce.Platform.Web/Startup.cs b/src/VirtoCommerce.Platform.Web/Startup.cs
@@ -100,21 +100,10 @@ public Startup(IConfiguration configuration, IWebHostEnvironment hostingEnvironm
         public void ConfigureServices(IServiceCollection services)
         {
             // Use temporary bootstrap logger (which will be replaced with configured version later) until DI initialization completed
-            Log.Logger = new LoggerConfiguration().ReadFrom.Configuration(Configuration).CreateBootstrapLogger();
-
-            services.AddSerilog((serviceProvider, loggerConfiguration) =>
-            {
-                _ = loggerConfiguration.ReadFrom.Configuration(Configuration);
-
-                // Enrich configuration from external sources
-                var configurationServices = serviceProvider.GetService<IEnumerable<ILoggerConfigurationService>>();
-                foreach (var service in configurationServices)
-                {
-                    service.Configure(loggerConfiguration);
-                }
-                // Preserve static logger (i.e. create new logger for DI, instead of reconfiguring existing)
-                // to avoid exception about frozen logger because BuildServiceProvider is called multiple times
-            }, preserveStaticLogger: true);
+            var loggerConfiguration = new LoggerConfiguration()
+                .WriteTo.Console()
+                .WriteTo.Debug();
+            Log.Logger = loggerConfiguration.CreateBootstrapLogger();
 
             Log.ForContext<Startup>().Information("Virto Commerce is loading");
 
@@ -513,7 +502,22 @@ public void ConfigureServices(IServiceCollection services)
             services.AddOptions<ExternalModuleCatalogOptions>().Bind(Configuration.GetSection("ExternalModules")).ValidateDataAnnotations();
             services.AddExternalModules();
 
-            //HangFire
+            // Serilog (initialize after all modules DLLs were loaded)
+            services.AddSerilog((serviceProvider, loggerConfiguration) =>
+            {
+                _ = loggerConfiguration.ReadFrom.Configuration(Configuration);
+
+                // Enrich configuration from external sources
+                var configurationServices = serviceProvider.GetService<IEnumerable<ILoggerConfigurationService>>();
+                foreach (var service in configurationServices)
+                {
+                    service.Configure(loggerConfiguration);
+                }
+                // Preserve static logger (i.e. create new logger for DI, instead of reconfiguring existing)
+                // to avoid exception about frozen logger because BuildServiceProvider is called multiple times
+            }, preserveStaticLogger: true);
+
+            // HangFire
             services.AddHangfire(Configuration);
 
             // Register the Swagger generator