Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Github/Linkedin functions user friendly #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make Github/Linkedin functions user friendly #26

wants to merge 2 commits into from

Conversation

k-kali
Copy link
Collaborator

@k-kali k-kali commented Apr 2, 2021 •
edited
Loading

Rewrite the functions to be more user friendly:

  • shorten functions names
  • make so you don't have to ping yourself to set/get your info
  • maybe turn into one function instead of both get_github and set_github

@k-kali k-kali changed the title some DiscordUserModel functions Database - Get and set github username functions Apr 2, 2021
aomi
aomi reviewed Apr 2, 2021
View reviewed changes
database.py Outdated
@@ -1,6 +1,6 @@
import os
from pynamodb.models import Model
from pynamodb.attributes import NumberAttribute
from pynamodb.attributes import (NumberAttribute, UnicodeAttribute)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in brackets now?

@aomi aomi requested a review from a team April 5, 2021 21:11
@k-kali k-kali changed the title Database - Get and set github username functions Github/Linkedin functions Jul 21, 2021
@k-kali k-kali changed the title Github/Linkedin functions Make Github/Linkedin functions user friendly Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aomi aomi aomi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-kali @aomi