feat: RateMyProf integration #494
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
functions/src/constants.ts
Dismissed
|
|
||
| export const RMP_GRAPHQL_URL = 'https://www.ratemyprofessors.com/graphql'; | ||
| export const RMP_UVIC_ID = 'U2Nob29sLTE0ODg='; | ||
| export const RMP_AUTH_TOKEN = 'dGVzdDp0ZXN0'; |
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical
There was a problem hiding this comment.
These aren't actually credentials, the auth token is public and not cycled on ratemyprof's end. Weird it's needed at all, but blame them.
| {meetingTimes.map( | ||
| (m, i) => | ||
| m.instructors.length > 0 && ( | ||
| <Td> |
There was a problem hiding this comment.
getting error for missing key here
| @@ -77,7 +91,7 @@ export function Schedule({ meetingTimes }: ScheduleProps): JSX.Element { | |||
| {/* TODO: verify if we can safely exclude this for most cases */} | |||
| {/* <Th>Schedule Type</Th> */} | |||
| <Th>Location</Th> | |||
| <Th>Instructors</Th> | |||
| {professor.length > 0 && <Th>Instructors</Th>} | |||
There was a problem hiding this comment.
I'm confused on the professor variable here, since it's still an array will all profs from that course no? why not use m.instructors length directly?
There was a problem hiding this comment.
I'll clean this up
Since it's graphql, it has a schema built in. Nothing is public, but when you put |
Description
Closes #436
Screenshots
Checklist
General Comments