Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][MIG][17.0] mail: missing fields renames #674

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

haumenphai
Copy link

@haumenphai haumenphai commented Jul 12, 2024

@haumenphai haumenphai changed the title [FIX][MIG] mail: missing rename columns [FIX][MIG][17.0] mail: missing fields renames Jul 12, 2024
@haumenphai
Copy link
Author

PR FIX: https://github.com/odoo/odoo/pull/ 172881

Traceback (most recent call last):
  File "/home/runner/work/OpenUpgrade/OpenUpgrade/odoo/odoo/modules/registry.py", line 113, in new
    odoo.modules.load_modules(registry, force_demo, status, update_module)
  File "/home/runner/work/OpenUpgrade/OpenUpgrade/odoo/odoo/modules/loading.py", line 536, in load_modules
    env['ir.model.data']._process_end(processed_modules)
  File "/home/runner/work/OpenUpgrade/OpenUpgrade/openupgrade/openupgrade_framework/odoo_patch/odoo/addons/base/models/ir_model.py", line 77, in _process_end
    return IrModelData._process_end._original_method(self, modules)
  File "/home/runner/work/OpenUpgrade/OpenUpgrade/odoo/odoo/addons/base/models/ir_model.py", line 2558, in _process_end
    self._process_end_unlink_record(record)
  File "/home/runner/work/OpenUpgrade/OpenUpgrade/odoo/addons/website/models/ir_model_data.py", line 36, in _process_end_unlink_record
    return super()._process_end_unlink_record(record)
  File "/home/runner/work/OpenUpgrade/OpenUpgrade/odoo/odoo/addons/base/models/ir_model.py", line 2487, in _process_end_unlink_record
    record.unlink()
  File "/home/runner/work/OpenUpgrade/OpenUpgrade/odoo/addons/mail/models/ir_model_fields.py", line 52, in unlink
    'sequence': self.env[field.model_id.model]._mail_track_get_field_sequence(field.name),
  File "/home/runner/work/OpenUpgrade/OpenUpgrade/odoo/addons/mail/models/models.py", line 181, in _mail_track_get_field_sequence
    self._fields[fname], 'tracking',
KeyError: 'phone'

@phamgiang2510
Copy link
Collaborator

@haumenphai PR này depend vào PR phía Odoo kia ah chú?

@haumenphai
Copy link
Author

@haumenphai PR này depend vào PR phía Odoo kia ah chú?

vâng a

@phamgiang2510
Copy link
Collaborator

@haumenphai thế chờ lâu đấy, khéo chú patch cái method _mail_track_get_field_sequence vào trong thư mục openupgrade_framework/odoo_patch/odoo/addons/base luôn, dùng try except nếu gặp lỗi KeyError thì đi search field rồi xử lý tiếp

@haumenphai haumenphai force-pushed the v17_fix_mig_mail_1 branch 3 times, most recently from 962eef1 to 8a90d71 Compare July 12, 2024 06:50
@phamgiang2510 phamgiang2510 merged commit 6926676 into Viindoo:17.0 Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants