Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC][17.0] apriori.py: update apriori #670

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

haumenphai
Copy link

No description provided.

@haumenphai haumenphai changed the title [MISC] apriori.py: Declare changes to modules of pecc3 [MISC][17.0] apriori.py: Declare changes to modules of pecc3 Jul 2, 2024
@haumenphai haumenphai force-pushed the add_pecc3_module_change branch 2 times, most recently from 738da1a to 21cf499 Compare July 2, 2024 06:52
@phamgiang2510
Copy link
Collaborator

@anhbtit thử chạy xem có vấn đề gì ko nhé

@anhbtit
Copy link

anhbtit commented Jul 3, 2024

@phamgiang2510 Lúc chạy migration không có vấn đề gì phát sinh.
Chạy xong và truy cập instance thì log có báo WARNING và ERROR

Screenshot from 2024-07-03 08-43-05

@duong77476-viindoo
Copy link

image
Please fix 🙏

@haumenphai
Copy link
Author

image Please fix 🙏

Có vẻ không fix được rồi a
Screenshot from 2024-07-03 11-41-22

@duong77476-viindoo
Copy link

@haumenphai Thử thêm # noqa: B950 , có 1 chỗ ở 15 nó làm vậy bên repo Openupgrade Oca gốc :v

@haumenphai haumenphai force-pushed the add_pecc3_module_change branch 2 times, most recently from 65093f6 to 33801c5 Compare July 3, 2024 06:05
@phamgiang2510
Copy link
Collaborator

phamgiang2510 commented Jul 3, 2024

@phamgiang2510 Lúc chạy migration không có vấn đề gì phát sinh. Chạy xong và truy cập instance thì log có báo WARNING và ERROR

Screenshot from 2024-07-03 08-43-05

@haumenphai khai báo thêm 1 số module này giúp a nhé:

  • viin_project_role_progress rename thành viin_pecc3_project_role_progress
  • viin_pecc3_project_budget, viin_pecc3_project_hr_expense_budget, viin_pecc3_project_role_budget merge vào viin_pecc3_project_info
  • viin_searchpanel_horizontal_scrollbar merge vào web
  • viin_spreadsheet_dashboard merge vào spreadsheet_dashboard
  • viin_project_view_all_tasks merge vào project
  • to_mail_notif_and_email merge vào mail
  • viin_analytic_tag: con này thì cần nâng cấp, để a báo lại SP

cc @anhbtit

"viin_pecc3_project_hr_expense_budget": "viin_pecc3_project_info",
"viin_pecc3_project_role_budget": "viin_pecc3_project_info",
"viin_searchpanel_horizontal_scrollbar": "web",
"viin_spreadsheet_dashboard": "spreadsheet_dashboard",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

viin_spreadsheet_dashboard là của repo tvtmaaddons

@haumenphai haumenphai changed the title [MISC][17.0] apriori.py: Declare changes to modules of pecc3 [MISC][17.0] apriori.py: update apriori Jul 3, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haumenphai các module đều đang sắp xếp theo bảng chữ cái, sắp xếp lại giúp a

@phamgiang2510 phamgiang2510 merged commit 0d9b4aa into Viindoo:17.0 Jul 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants