forked from tvtma/OpenUpgrade
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX][17.0] account: set company for tax_group #658
Merged
royle-vietnam
merged 4 commits into
Viindoo:17.0
from
duong77476-viindoo:v17_fix_accounting_mig
Jun 7, 2024
Merged
[FIX][17.0] account: set company for tax_group #658
royle-vietnam
merged 4 commits into
Viindoo:17.0
from
duong77476-viindoo:v17_fix_accounting_mig
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duong77476-viindoo
force-pushed
the
v17_fix_accounting_mig
branch
from
June 7, 2024 04:20
9fab3f1
to
195769c
Compare
openupgrade_scripts/scripts/l10n_vn/17.0.2.0.3/pre-migration.py
Outdated
Show resolved
Hide resolved
duong77476-viindoo
force-pushed
the
v17_fix_accounting_mig
branch
2 times, most recently
from
June 7, 2024 04:30
a764617
to
9dd2573
Compare
-Forget to set company_id for tax_group [FIX] l10n_vn: wrong value for pre-fix company_id of xml_id - if just select id from res_company then env.cr.fetchall() will return like [(1, ), (2, )]
duong77476-viindoo
force-pushed
the
v17_fix_accounting_mig
branch
from
June 7, 2024 04:34
9dd2573
to
330a4bc
Compare
royle-vietnam
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Forget to set company_id for tax_group
[FIX] l10n_vn: wrong value for pre-fix company_id of xml_id