Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][17.0] account: migration to 17.0 #652

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

@duong77476-viindoo duong77476-viindoo marked this pull request as draft May 31, 2024 10:06
@duong77476-viindoo duong77476-viindoo force-pushed the v17_mig_account branch 9 times, most recently from e88c14f to ad3183a Compare June 3, 2024 09:47
@duong77476-viindoo duong77476-viindoo changed the title V17 mig account [MIG][17.0] account: migration to 17.0 Jun 3, 2024
@duong77476-viindoo
Copy link
Author

duong77476-viindoo commented Jun 3, 2024

todo:

  • Thuế bị duplicate

  • Check lại payment term

  • onboarding migration đang ko ổn

@duong77476-viindoo duong77476-viindoo force-pushed the v17_mig_account branch 3 times, most recently from c2fcbae to f1a4091 Compare June 6, 2024 09:29
SET tax_group_id = {new_tax_group_id}
WHERE tax_group_id = {tax_group_id} AND company_id = {company_id}
""",
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duong77476-viindoo anh có sửa lại code để nó đơn giản hơn, vẫn theo logic của em, nó sẽ như này
đồng thời khi copy tax group thì anh không fix trường, vì nếu module nào đó thêm trường thì sẽ không thể kế thừa được

lấy tất cả tax_group_id từ account_tax để biết xem cái nào cần tạo mới cái nào cần nhân bản (cái đầu tiên sẽ luôn đổi xml, các cái tiếp theo sẽ nhân bản từ cái thứ nhất)

Copy link
Collaborator

@royle-vietnam royle-vietnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@royle-vietnam royle-vietnam merged commit 94d12ec into Viindoo:17.0 Jun 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants