Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][17.0] project_todo: migrate to 17.0 #643

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

@haumenphai haumenphai force-pushed the v17_mig_project_todo branch 2 times, most recently from 495775d to 5922711 Compare May 25, 2024 01:58
@haumenphai haumenphai force-pushed the v17_mig_project_todo branch 3 times, most recently from dc4d0bd to 3b79029 Compare June 4, 2024 09:17
@royle-vietnam
Copy link
Collaborator

@duong77476-viindoo em review và approve nhé

Copy link

@duong77476-viindoo duong77476-viindoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ngoài ra, trong file docsource ở line module note thì e thêm Done vào để thể hiện là có làm gì đó, a check mấy phiên bản trước cũng hay làm thế

Copy link

@duong77476-viindoo duong77476-viindoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lỗi pre-commit
Ngoài ra thì LGTM

@royle-vietnam royle-vietnam merged commit e8819b3 into Viindoo:17.0 Jun 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants