Feat / WCAG validation per page using axe-playwright
#192
+2,267
−2,650
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| import { testConfigs } from '@jwp/ott-testing/constants'; | ||
|
|
||
| import { LoginContext } from '#utils/password_utils'; | ||
| import constants from '#utils/constants'; | ||
|
|
||
| Feature('Accessibility'); | ||
|
|
||
| let paidLoginContext: LoginContext; | ||
|
|
||
| const disableRetryFailedStep = (test: { disableRetryFailedStep: boolean }): void => { | ||
| test.disableRetryFailedStep = true; | ||
| }; | ||
|
|
||
| Scenario('WCAG compliant - Home Page', async ({ I }) => { | ||
| I.useConfig(testConfigs.basicNoAuth); | ||
| I.amOnPage('/'); | ||
| I.checkA11y(); | ||
| }).config(disableRetryFailedStep); | ||
|
|
||
| Scenario('WCAG compliant - Video Detail Page', async ({ I }) => { | ||
| I.useConfig(testConfigs.basicNoAuth); | ||
| I.amOnPage('/m/awWEFyPu/big-buck-bunny'); | ||
| I.checkA11y(); | ||
| }).config(disableRetryFailedStep); | ||
|
|
||
| Scenario('WCAG compliant - Playlist Page', async ({ I }) => { | ||
| I.amOnPage('/p/dGSUzs9o/'); // "Films" page | ||
| I.checkA11y(); | ||
| }).config(disableRetryFailedStep); | ||
|
|
||
| Scenario('WCAG compliant - Video Detail Inline Page', async ({ I }) => { | ||
| I.useConfig(testConfigs.inlinePlayer); | ||
| I.amOnPage('/m/awWEFyPu/big-buck-bunny'); | ||
| I.checkA11y(); | ||
| }).config(disableRetryFailedStep); | ||
|
|
||
| Scenario('WCAG compliant - Search Page with results', async ({ I }) => { | ||
| I.useConfig(testConfigs.basicNoAuth); | ||
| I.amOnPage('/q/Caminandes'); | ||
| I.checkA11y(); | ||
| }).config(disableRetryFailedStep); | ||
|
|
||
| Scenario('WCAG compliant - Search Page containing no results', async ({ I }) => { | ||
| I.useConfig(testConfigs.basicNoAuth); | ||
| I.amOnPage('/q/querywithoutresults'); | ||
| I.checkA11y(); | ||
| }).config(disableRetryFailedStep); | ||
|
|
||
| Scenario('WCAG compliant - Player Page', async ({ I }) => { | ||
| I.useConfig(testConfigs.basicNoAuth); | ||
| I.amOnPage('/m/awWEFyPu/big-buck-bunny?r=dGSUzs9o&play=1'); | ||
| I.checkA11y(); | ||
| }).config(disableRetryFailedStep); | ||
|
|
||
| Scenario('WCAG compliant - Live Page (EPG)', async ({ I }) => { | ||
| I.useConfig(testConfigs.basicNoAuth); | ||
| I.amOnPage('/p/fWpLtzVh/?channel=Uh7zcqVm/'); | ||
| I.checkA11y(null, { | ||
| ignore: [ | ||
| // It is a known issue that the EPG is not fully accessible due to the planby EPG package | ||
| { id: 'scrollable-region-focusable', selector: '[class^="css-"]' }, | ||
| ], | ||
| }); | ||
| }).config(disableRetryFailedStep); | ||
|
|
||
| // Account Pages | ||
|
|
||
| Scenario('WCAG compliant - Account Page', async ({ I }) => { | ||
| I.useConfig(testConfigs.jwpAuth); | ||
| I.amOnPage('/u/my-account'); | ||
| I.checkA11y(); | ||
| }).config(disableRetryFailedStep); | ||
|
|
||
| Scenario('WCAG compliant - Payments Page', async ({ I }) => { | ||
| I.useConfig(testConfigs.jwpAuth); | ||
| I.amOnPage('/u/payments'); | ||
| I.checkA11y(); | ||
| }).config(disableRetryFailedStep); | ||
|
|
||
| Scenario('WCAG compliant - Favorites Page', async ({ I }) => { | ||
| I.useConfig(testConfigs.jwpAuth); | ||
| I.amOnPage('/u/favorites'); | ||
| I.checkA11y(); | ||
| }).config(disableRetryFailedStep); | ||
|
|
||
| // Modals | ||
|
|
||
| Scenario('WCAG compliant - Signup Modal - CLEENG', async ({ I }) => { | ||
| I.useConfig(testConfigs.cleengAuthvod); | ||
| I.amOnPage('/?u=create-account'); | ||
| I.checkA11y(); | ||
| }).config(disableRetryFailedStep); | ||
|
|
||
| Scenario('WCAG compliant - Sign in Modal - CLEENG', async ({ I }) => { | ||
| I.useConfig(testConfigs.cleengAuthvod); | ||
| I.amOnPage('/?u=login'); | ||
| I.checkA11y(); | ||
| }).config(disableRetryFailedStep); | ||
|
|
||
| Scenario('WCAG compliant - Signup Modal - JWP', async ({ I }) => { | ||
| I.useConfig(testConfigs.jwpAuth); | ||
| I.amOnPage('/?u=create-account'); | ||
| I.checkA11y({ | ||
| rules: { | ||
| // This rule is disabled because this component does have a label prop, | ||
| // but is not set in the test configuration | ||
| 'label-title-only': { | ||
| enabled: false, | ||
| }, | ||
| }, | ||
| }); | ||
| }).config(disableRetryFailedStep); | ||
|
|
||
| Scenario('WCAG compliant - Sign in Modal - JWP', async ({ I }) => { | ||
| I.useConfig(testConfigs.jwpAuth); | ||
| I.amOnPage('/?u=login'); | ||
| I.checkA11y(); | ||
| }).config(disableRetryFailedStep); | ||
|
|
||
| Scenario('WCAG compliant - Choose Offer Modal', async ({ I }) => { | ||
| I.useConfig(testConfigs.svod); | ||
| paidLoginContext = await I.registerOrLogin(paidLoginContext); | ||
|
There was a problem hiding this comment. This seems like a weird convention. I also see this is not your idea, but it is used like this in other tests. Is this really needed to make it work? I have the assumption it could be left empty and still work. Also, I would move the |
||
| I.amOnPage(constants.offersUrl); | ||
| I.checkA11y(); | ||
| }).config(disableRetryFailedStep); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazingly no failures for the player!? Awesome!