Implement API for getting memory allocation statistics #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@valyala please take a look? |
|
For the record, our need for the metrics arose from a missed Reset operation which resulted in an eventual OOM. None of our monitoring systems detected the issue ahead of time since the memory was not reported by Go. Would be nice to be able to track it at least explicitly to have an early warning for similar issues in the future. |
|
I'm curious how you got an OOM. Did you set |
|
No, we had ephemeral cache instances and a refactor lost the Reset when the outer temporary object got cleaned up. |
|
@valyala any chance to take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a API for retrieving offheap memory allocation statistics.
Fastcache allocates the offheap memory "manually" in order to mitigate the
overhead of golang garbage collection. However it also means this part of
memory won't be tracked by golang standard metrics.
In order to accurately know how much memory is used by our application,
we need this additional statistics to sum up the standard memory usage.