-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/regexutil: vendor syntax standard lib in Go 1.23 as a workaround #6934
base: master
Are you sure you want to change the base?
Conversation
3bbebe0
to
cf613f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach with vendoring of regexp/syntax package with the bugfix looks interesting as a temporary workaround for the issue in this package!
Please refer the created issue at Go repository here. |
a17eca0
to
06950e2
Compare
Let's put this PR on-hold. The change seems too intrusive, while the effect of the mentioned bug seems pretty low. Probably, we should wait for this to be fixed on Go side and the use newer Go version instead. |
Describe Your Changes
Fix #6911
While waiting for the changes to be updated in Go's mainstream, I vendored the syntax package in Go 1.23, changed the call to the local syntax package, and the only modification to the vendored syntax package is the new
calcFlagsI()
function.New version: