Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement spatially symmetric LoopTNR #7

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Conversation

VictorVanthilt
Copy link
Owner

@dartsushi Implemented spatially symmetric LoopTNR (which i coined SLoopTNR) and I adapted it to fit within this project.
There are three important notes to make here:

  1. The internal code uses a different leg-ordering convention (which the user does not have to worry about, use it as you would any other scheme).
  2. The implementation is not (yet) compatible with tensors living in special spaces like the classical_ising_symmetric model.
  3. The implementation only works for real-valued tensors (and should error if you hand it anything else).

@VictorVanthilt VictorVanthilt merged commit dc6d972 into master Jan 24, 2025
1 of 2 checks passed
VictorVanthilt added a commit that referenced this pull request Jan 24, 2025
VictorVanthilt added a commit that referenced this pull request Jan 24, 2025
* add Zygote and OptimKit as dependencies

* implement SLoopTNR

* add default `LBFGS` parameters

* add `SLoopTNR` to the spaces testset

* remove `SLoopTNR` from spaces test again

* add `SLoopTNR` to Ising test

* add comment to `SLoopTNR` implementation

* formatting

 Co-authored-by: dartsushi <[email protected]>
VictorVanthilt added a commit that referenced this pull request Jan 24, 2025
* add Zygote and OptimKit as dependencies

* implement SLoopTNR

* add default `LBFGS` parameters

* add `SLoopTNR` to the spaces testset

* remove `SLoopTNR` from spaces test again

* add `SLoopTNR` to Ising test

* add comment to `SLoopTNR` implementation

* formatting

Co-authored-by: dartsushi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant