Disk should return the size of the disk #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneri
changed the title
Disk key should give the size of the first disk in GB, not the number of hard drive. During the nova boot, nova will compare this value with the minimal mandatory size associated with the Glance image. Without this patch, nova will always fail and returns the "no valid host was found" message as soon as the size is greater than 1.
This parameter allow the user to manually specify what NIC should be used to boot the system. There is three reasons to prefer this solution: - depending on how the NIC are negotiated, we may have a 10Gb NIC seen has a 1G NIC. In this case, idracula will pick the wrong MAC. - this speed up the discovery - we don't need anymore to turn the nodes on first.
For the moment, ironic ramdisk doesn't support PERC RAID. It makes more sense to use the size of the first physical disk. With this patch, it's also possible to drop all the virtual disk configuration and do JBOD instead.
goneri
pushed a commit
to goneri/idracula
that referenced
this pull request
Jan 19, 2016
Default to IPMI instead of iDrac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disk key should give the size of the first disk in GB, not the number of hard
drive. During the nova boot, nova will compare this value with the
minimal mandatory size associated with the Glance image.
Without this patch, nova will always fail and returns the "no valid host was found"
message as soon as the size is greater than 1GB.
See: https://www.rdoproject.org/install/instack-faq/#What_is_the_NODES_JSON_file_format.3F