Pointer value improvements #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrays decay to pointer values Handle address-of locals as well as globals
Vexu
approved these changes
Oct 17, 2024
test/cases/ast/_Float16.c
Outdated
| @@ -30,7 +30,7 @@ fn_def: 'fn (x: int, ...) void' | |||
| builtin_call_expr: 'void' | |||
| name: __builtin_va_start | |||
| args: | |||
| implicit_cast: (array_to_pointer) 'va_list': '*d[1]struct __va_list_tag' | |||
| implicit_cast: (array_to_pointer) 'va_list': '*d[1]struct __va_list_tag' (value: ) | |||
There was a problem hiding this comment.
Would be nice if pointer values printed the offset (if non-zero).
There was a problem hiding this comment.
I meant to ask about this - should I just print the offset (without the name of the variable)?
There was a problem hiding this comment.
Printing the NodeIndex probably won't be too useful so I guess just the offset is good for now. Maybe add something to distinguish it from just ints.
There was a problem hiding this comment.
What if we change the return type of Value.print from @TypeOf(w).Error!void to something like @TypeOf(w).Error!?NestedPrint where NestedPrint is
const NestedPrint = union(enum) {
pointer: struct {
node: u32,
offset: Value,
},
};and then the caller can handle it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow array-to-pointer decay to produce a pointer value
Handle address-of locals as well as globals
Rename "reloc" to pointer for consistency