Issue a warning on gnu void pointer arithmetic

Vexu · Oct 1, 2024 · ecd5c72 · ecd5c72
1 parent 406f323
commit ecd5c72
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 0 deletions.
diff --git a/src/aro/Diagnostics.zig b/src/aro/Diagnostics.zig
@@ -196,6 +196,7 @@ pub const Options = struct {
     @"pointer-bool-conversion": Kind = .default,
     @"string-conversion": Kind = .default,
     @"gnu-auto-type": Kind = .default,
+    @"gnu-pointer-arith": Kind = .default,
     @"gnu-union-cast": Kind = .default,
     @"pointer-sign": Kind = .default,
     @"fuse-ld-path": Kind = .default,

diff --git a/src/aro/Diagnostics/messages.def b/src/aro/Diagnostics/messages.def
@@ -2165,6 +2165,12 @@ auto_type_extension
     .kind = .off
     .pedantic = true
 
+gnu_pointer_arith
+    .msg = "arithmetic on pointers to void is a GNU extension"
+    .opt = W("gnu-pointer-arith")
+    .kind = .off
+    .pedantic = true
+
 auto_type_not_allowed
     .msg = "'__auto_type' not allowed in {s}"
     .kind = .@"error"

diff --git a/src/aro/Parser.zig b/src/aro/Parser.zig
@@ -5492,6 +5492,9 @@ pub const Result = struct {
                 // if both aren't arithmetic one should be pointer and the other an integer
                 if (a_ptr == b_ptr or a_int == b_int) return a.invalidBinTy(tok, b, p);
 
+                if (a.ty.isVoidStar() or b.ty.isVoidStar())
+                    try p.errTok(.gnu_pointer_arith, tok);
+
                 // Do integer promotions but nothing else
                 if (a_int) try a.intCast(p, a.ty.integerPromotion(p.comp), tok);
                 if (b_int) try b.intCast(p, b.ty.integerPromotion(p.comp), tok);
@@ -5504,6 +5507,9 @@ pub const Result = struct {
                 // if both aren't arithmetic then either both should be pointers or just a
                 if (!a_ptr or !(b_ptr or b_int)) return a.invalidBinTy(tok, b, p);
 
+                if (a.ty.isVoidStar())
+                    try p.errTok(.gnu_pointer_arith, tok);
+
                 if (a_ptr and b_ptr) {
                     if (!a.ty.eql(b.ty, p.comp, false)) try p.errStr(.incompatible_pointers, tok, try p.typePairStr(a.ty, b.ty));
                     a.ty = p.comp.types.ptrdiff;
@@ -7150,6 +7156,8 @@ fn unExpr(p: *Parser) Error!Result {
 
             var operand = try p.castExpr();
             try operand.expect(p);
+            if (operand.ty.isVoidStar())
+                try p.errTok(.gnu_pointer_arith, tok);
             if (!operand.ty.isScalar())
                 try p.errStr(.invalid_argument_un, tok, try p.typeStr(operand.ty));
             if (operand.ty.isComplex())
@@ -7176,6 +7184,8 @@ fn unExpr(p: *Parser) Error!Result {
 
             var operand = try p.castExpr();
             try operand.expect(p);
+            if (operand.ty.isVoidStar())
+                try p.errTok(.gnu_pointer_arith, tok);
             if (!operand.ty.isScalar())
                 try p.errStr(.invalid_argument_un, tok, try p.typeStr(operand.ty));
             if (operand.ty.isComplex())
@@ -7475,6 +7485,8 @@ fn suffixExpr(p: *Parser, lhs: Result) Error!Result {
             defer p.tok_i += 1;
 
             var operand = lhs;
+            if (operand.ty.isVoidStar())
+                try p.errTok(.gnu_pointer_arith, p.tok_i);
             if (!operand.ty.isScalar())
                 try p.errStr(.invalid_argument_un, p.tok_i, try p.typeStr(operand.ty));
             if (operand.ty.isComplex())
@@ -7493,6 +7505,8 @@ fn suffixExpr(p: *Parser, lhs: Result) Error!Result {
             defer p.tok_i += 1;
 
             var operand = lhs;
+            if (operand.ty.isVoidStar())
+                try p.errTok(.gnu_pointer_arith, p.tok_i);
             if (!operand.ty.isScalar())
                 try p.errStr(.invalid_argument_un, p.tok_i, try p.typeStr(operand.ty));
             if (operand.ty.isComplex())

diff --git a/test/cases/gnu pointer arith.c b/test/cases/gnu pointer arith.c
@@ -0,0 +1,19 @@
+//aro-args -Wgnu-pointer-arith
+
+void foo(void *a, void *b) {
+    b - a;
+    a - 1;
+    a + 1;
+    ++a;
+    --a;
+    b++;
+    b--;
+}
+
+#define EXPECTED_ERRORS "gnu pointer arith.c:4:7: warning: arithmetic on pointers to void is a GNU extension [-Wgnu-pointer-arith]"\
+                        "gnu pointer arith.c:5:7: warning: arithmetic on pointers to void is a GNU extension [-Wgnu-pointer-arith]"\
+                        "gnu pointer arith.c:6:7: warning: arithmetic on pointers to void is a GNU extension [-Wgnu-pointer-arith]"\
+                        "gnu pointer arith.c:7:5: warning: arithmetic on pointers to void is a GNU extension [-Wgnu-pointer-arith]"\
+                        "gnu pointer arith.c:8:5: warning: arithmetic on pointers to void is a GNU extension [-Wgnu-pointer-arith]"\
+                        "gnu pointer arith.c:9:6: warning: arithmetic on pointers to void is a GNU extension [-Wgnu-pointer-arith]"\
+                        "gnu pointer arith.c:10:6: warning: arithmetic on pointers to void is a GNU extension [-Wgnu-pointer-arith]"