-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tfhub object detection improvements #50
Conversation
deployment/tfhub/object-detection/url/object-detection-url-deploy.ipynb
Outdated
Show resolved
Hide resolved
deployment/tfhub/object-detection/base64/object-detection-base64-predict.ipynb
Outdated
Show resolved
Hide resolved
deployment/tfhub/object-detection/base64/object-detection-base64-predict.ipynb
Outdated
Show resolved
Hide resolved
deployment/tfhub/object-detection/base64/object-detection-base64-predict.ipynb
Outdated
Show resolved
Hide resolved
deployment/tfhub/object-detection/base64/object-detection-base64-predict.ipynb
Outdated
Show resolved
Hide resolved
deployment/tfhub/object-detection/url/object-detection-url-predict.ipynb
Outdated
Show resolved
Hide resolved
deployment/tfhub/object-detection/url/object-detection-url-predict.ipynb
Outdated
Show resolved
Hide resolved
deployment/tfhub/object-detection/url/object-detection-url-predict.ipynb
Outdated
Show resolved
Hide resolved
deployment/tfhub/object-detection/url/object-detection-url-predict.ipynb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cfascina In addition to my feedback above, I have an additional proposal. Let me know what you think:
The client's ModelAPI()
current has a requirement (Slack thread)
arguments to ModelAPI() must be lists of data
Could we change these models' predict()
to take a list and return a list? Something like
def predict(self, data):
result = []
for image in data:
file_name, img = image
result.append(self.detect_objects(file_name, img))
return result
Then we should be able to correctly match model API to this new format
model_api = ModelAPI(
[
['file_name', 'img']
],
[{
'file_name': '',
'has_car': False,
'score': 0,
'bboxes': {
'ymin': 0,
'xmin': 0,
'ymax': 0,
'xmax': 0
}
}]
),
Co-authored-by: Liu <[email protected]>
…com/VertaAI/examples into tfhub-object-detection-improvements
@liuverta, the way you suggested is clearer to me. I made some changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you so much for your work on this
Improvements at tfhub computer vision models (base64 and URL versions) after reviews.
Risks and Area of Effect
Testing
Reverting