-
Notifications
You must be signed in to change notification settings - Fork 325
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #5 from VeriorPies/Develop
Fix issue with assets modified alert shown when nothing is actually being saved. Add preference options
- Loading branch information
Showing
5 changed files
with
135 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| using System.Collections; | ||
| using System.Collections.Generic; | ||
| using UnityEngine; | ||
| using UnityEditor; | ||
|
|
||
| namespace ParrelSync | ||
| { | ||
| /// <summary> | ||
| /// To add value caching for <see cref="EditorPrefs"/> functions | ||
| /// </summary> | ||
| public class BoolPreference | ||
| { | ||
| public string key { get; private set; } | ||
| public bool defaultValue { get; private set; } | ||
| public BoolPreference(string key, bool defaultValue) | ||
| { | ||
| this.key = key; | ||
| this.defaultValue = defaultValue; | ||
| } | ||
|
|
||
| private bool? valueCache = null; | ||
|
|
||
| public bool GetValue() | ||
| { | ||
| if (valueCache == null) | ||
| valueCache = EditorPrefs.GetBool(key, defaultValue); | ||
|
|
||
| return (bool)valueCache; | ||
| } | ||
|
|
||
| public void SetValue(bool value) | ||
| { | ||
| if (valueCache == value) | ||
| return; | ||
|
|
||
| EditorPrefs.SetBool(key, value); | ||
| valueCache = value; | ||
| Debug.Log("Editor preference updated. key: " + key + ", value: " + value); | ||
| } | ||
|
|
||
| public void ClearValue() | ||
| { | ||
| EditorPrefs.DeleteKey(key); | ||
| valueCache = null; | ||
| } | ||
| } | ||
|
|
||
| public class Preferences : EditorWindow | ||
| { | ||
| [MenuItem("ParrelSync/Preferences", priority = 1)] | ||
| private static void InitWindow() | ||
| { | ||
| Preferences window = (Preferences)EditorWindow.GetWindow(typeof(Preferences)); | ||
| window.titleContent = new GUIContent(ClonesManager.ProjectName + " Preferences"); | ||
| window.Show(); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Disable asset saving in clone editors? | ||
| /// </summary> | ||
| public static BoolPreference AssetModPref = new BoolPreference("ParrelSync_DisableClonesAssetSaving", true); | ||
|
|
||
| /// <summary> | ||
| /// In addition of checking the existence of UnityLockFile, | ||
| /// also check is the is the UnityLockFile being opened. | ||
| /// </summary> | ||
| public static BoolPreference AlsoCheckUnityLockFileStaPref = new BoolPreference("ParrelSync_CheckUnityLockFileOpenStatus", true); | ||
|
|
||
| private void OnGUI() | ||
| { | ||
| if (ClonesManager.IsClone()) | ||
| { | ||
| EditorGUILayout.HelpBox( | ||
| "This is a clone project. Please use the original project editor to change preferences.", | ||
| MessageType.Info); | ||
| return; | ||
| } | ||
|
|
||
| GUILayout.BeginVertical("HelpBox"); | ||
| GUILayout.Label("Preferences"); | ||
| GUILayout.BeginVertical("GroupBox"); | ||
|
|
||
| AssetModPref.SetValue( | ||
| EditorGUILayout.ToggleLeft("(recommended) Disable asset saving in clone editors- require re-open clone editors", | ||
| AssetModPref.GetValue()) | ||
| ); | ||
|
|
||
|
|
||
| AlsoCheckUnityLockFileStaPref.SetValue( | ||
| EditorGUILayout.ToggleLeft("Also check UnityLockFile lock status while checking clone projects running status", | ||
| AlsoCheckUnityLockFileStaPref.GetValue()) | ||
| ); | ||
|
|
||
|
|
||
| GUILayout.EndVertical(); | ||
| if (GUILayout.Button("Reset to default")) | ||
| { | ||
| AssetModPref.ClearValue(); | ||
| AlsoCheckUnityLockFileStaPref.ClearValue(); | ||
| Debug.Log("Editor preferences cleared"); | ||
| } | ||
| GUILayout.EndVertical(); | ||
| } | ||
| } | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 1.3.2 | ||
| 1.3.3 |