Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported argument minimize from additional parameters in Python binding #469

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

Adda0
Copy link
Collaborator

@Adda0 Adda0 commented Nov 21, 2024

This PR removes the documentation string allowing to pass minimize to additional params dictionary in Python binding. The minimize parameter have been removed from the C++ API (#410), and we have forgotten to update the Python interface.

This PR closes #458.

@Adda0 Adda0 requested review from jurajsic and koniksedy November 21, 2024 07:17
Copy link
Collaborator

@koniksedy koniksedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Adda0 Adda0 merged commit 4482b91 into devel Nov 21, 2024
18 checks passed
@Adda0 Adda0 deleted the python-complement-sync-params branch November 21, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python binding: "minimize" parameter in complement does not work
3 participants