-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Toggle voice status using fifo pipe #609
base: main
Are you sure you want to change the base?
Conversation
5b5008a
to
08a9b60
Compare
this doesn't really work still. the first command works, but then runs into
|
Didn't have this issue, but now before creating a pipe file it checks whether it exists, if so removes the file and recreates. Also, it must now remove the file if Vesktop is closed. |
Works great for me. |
Hi there, thanks for creating this feature. I'm using it now and it works nicely. I did have to patch the implementation to allow non-wayland display servers though. I'm curious, is there a reason the keybinds are only enabled on wayland? It seems to be working fine and I'm running X11. |
Hey just wanted to say this is working great! Hoping we can get this or some other solution merged into main soon! |
Please show output of |
|
Looks like no problem with pipe creation. |
turns out my problem wasn't related to this. this works! |
Hi is this getting merged any time soon? |
I don't believe so, this PR is desired for other users who needs that feature. |
do I need to build it myself to use it? |
Yes. Use the instructions here, make sure to check out this branch right after cloning ( |
This PR adds not bad way for implementing basic keybinding for toggling mute and deaf statuses.
How it works?
This PR creates pipe file at
$XDG_RUNTIME_DIR/vesktop-ipc
which listens for stringsVCD_TOGGLE_SELF_MUTE
andVCD_TOGGLE_SELF_DEAF
and performs actions if this data is transfered to pipe.So with this if anywhere in the system you execute
echo "VCD_TOGGLE_SELF_MUTE" >> $XDG_RUNTIME_DIR/vesktop-ipc
then it will toggle mute.echo "VCD_TOGGLE_SELF_DEAF" >> $XDG_RUNTIME_DIR/vesktop-ipc
will toggle self deafness.How we can use it?
For example, in KDE systems, we can add custom keybinds which will execute a given command with needed signal:
I think in other DEs there must be ways to do similar actions.
If it will be merged, I think we must write these instructions into README.
This solution is really temporary and in future we must move to some native solutions for keybindings.