Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the menu bar for macOS #120

Merged
merged 8 commits into from
Sep 30, 2023
Merged

Optimize the menu bar for macOS #120

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a51b2cd
optimize the menu bar for macOS
X1nto Sep 22, 2023
376866b
add a small comment
X1nto Sep 22, 2023
7d8b346
group darwin-specific menus
X1nto Sep 22, 2023
d198fbb
Apply suggestions from code review
X1nto Sep 25, 2023
47b15a2
Merge branch 'main' into feat/macos-menubar
X1nto Sep 25, 2023
676473d
Merge branch 'main' into feat/macos-menubar
Vendicated Sep 25, 2023
4058eeb
satisfy eslint
X1nto Sep 26, 2023
60410c5
Merge branch 'main' into feat/macos-menubar
Vendicated Sep 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
dist
node_modules
.env
.DS_Store
.idea/
22 changes: 20 additions & 2 deletions src/main/mainWindow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,13 +182,31 @@ function initMenuBar(win: BrowserWindow) {
}
},
isDarwin && {
X1nto marked this conversation as resolved.
Show resolved Hide resolved
label: "Hide",
type: "separator"
},
isDarwin && {
label: "Settings",
accelerator: "CmdOrCtrl+,",
async click() {
mainWin.webContents.executeJavaScript("Vencord.Webpack.Common.SettingsRouter.open()")
}
},
isDarwin && {
type: "separator"
},
isDarwin && {
label: "Hide Vesktop", //Should probably remove the label, but it says "Hide VencordDesktop" instead of "Hide Vesktop"
role: "hide"
},
isDarwin && {
label: "Hide others",
role: "hideOthers"
},
isDarwin && {
role: "unhide",
},
isDarwin && {
type: "separator"
},
{
label: "Quit",
accelerator: wantCtrlQ ? "CmdOrCtrl+Q" : void 0,
Expand Down