Automatically allow struct access by json tags #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues where non-dicts structs are injected into VQL
output. If a custom struct has both fields and json tags which are not
consistent, then the user sees the json tags as the struct is
serialized. But then when they attempt to access the field by these
this will fail because the struct name is actually different:
type Foo struct {
SrcIP string `json:"src_ip"`
}
Accessing the field like `X.src_ip` was failing because the struct
does not really have a field `src_ip` - even though it looks like it
because the json serialized data does!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues where non-dicts structs are injected into VQL output. If a custom struct has both fields and json tags which are not consistent, then the user sees the json tags as the struct is serialized. But then when they attempt to access the field by these this will fail because the struct name is actually different:
type Foo struct {
SrcIP string
json:"src_ip"}
Accessing the field like
X.src_ipwas failing because the struct does not really have a fieldsrc_ip- even though it looks like it because the json serialized data does!