Bugfix: Off by one on parsing tags can return garbage LINE (#23)

Velocidex · Feb 7, 2024 · 85d57b5 · 85d57b5
1 parent 904f320
commit 85d57b5
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 6 deletions.
diff --git a/fixtures/SYSTEM_IDENTITY.golden b/fixtures/SYSTEM_IDENTITY.golden
@@ -1,5 +1,4 @@
 {"CreationTime":"2021-06-05T11:49:26Z","PhysicalProcessorCount":2,"CoresPerPhysicalProcessor":1,"LogicalProcessorsPerPhysicalProcessor":2,"MaximumMemory":2147483648,"OSMajor":10,"OSMinor":0,"OSBuildNumber":17763,"OSPlatformId":2,"ServicePackMajor":0,"ServicePackMinor":0,"OSSuiteMask":400,"OSProductType":3,"OSCurrentTimeZone":65116,"OSDaylightInEffect":true,"SystemManufacturer":"VMware, Inc.","SystemProductName":"VMware7,1","SystemSMBIOSUUID":"49704D56-60F8-0A10-1C09-0156A066C2C3","SystemSerialNumber":"VMware-56 4d 70 49 f8 60 10 0a-1c 09 01 56 a0 66 c2 c3","SystemDNSHostName":"WIN-M5M48LSM8UB","SystemDomainName":"WORKGROUP","OSSerialNumber":"00431-20000-00000-AA261","OSCountryCode":"1","OSLastBootUpTime":"20210605044708.644043-420"}
-{"CreationTime":"2021-06-05T11:49:26Z","PhysicalProcessorCount":2,"CoresPerPhysicalProcessor":1,"LogicalProcessorsPerPhysicalProcessor":2,"MaximumMemory":2147483648,"OSMajor":10,"OSMinor":0,"OSBuildNumber":17763,"OSPlatformId":2,"ServicePackMajor":0,"ServicePackMinor":0,"OSSuiteMask":400,"OSProductType":3,"OSCurrentTimeZone":65116,"OSDaylightInEffect":true}
 {"CreationTime":"2021-06-05T11:56:47Z","PhysicalProcessorCount":2,"CoresPerPhysicalProcessor":1,"LogicalProcessorsPerPhysicalProcessor":2,"MaximumMemory":2147483648,"OSMajor":10,"OSMinor":0,"OSBuildNumber":17763,"OSPlatformId":2,"ServicePackMajor":0,"ServicePackMinor":0,"OSSuiteMask":400,"OSProductType":3,"OSCurrentTimeZone":0,"OSDaylightInEffect":false,"SystemManufacturer":"VMware, Inc.","SystemProductName":"VMware7,1","SystemSMBIOSUUID":"49704D56-60F8-0A10-1C09-0156A066C2C3","SystemSerialNumber":"VMware-56 4d 70 49 f8 60 10 0a-1c 09 01 56 a0 66 c2 c3","SystemDNSHostName":"DC-0","SystemDomainName":"WORKGROUP","OSSerialNumber":"00431-20000-00000-AA261","OSCountryCode":"1","OSLastBootUpTime":"20210605150348.500000+000"}
 {"CreationTime":"2021-06-05T23:37:30Z","PhysicalProcessorCount":2,"CoresPerPhysicalProcessor":1,"LogicalProcessorsPerPhysicalProcessor":2,"MaximumMemory":2147483648,"OSMajor":10,"OSMinor":0,"OSBuildNumber":17763,"OSPlatformId":2,"ServicePackMajor":0,"ServicePackMinor":0,"OSSuiteMask":400,"OSProductType":3,"OSCurrentTimeZone":0,"OSDaylightInEffect":false,"SystemManufacturer":"VMware, Inc.","SystemProductName":"VMware7,1","SystemSMBIOSUUID":"49704D56-60F8-0A10-1C09-0156A066C2C3","SystemSerialNumber":"VMware-56 4d 70 49 f8 60 10 0a-1c 09 01 56 a0 66 c2 c3","SystemDNSHostName":"DC-1","SystemDomainName":"WORKGROUP","OSSerialNumber":"00431-20000-00000-AA261","OSCountryCode":"1","OSLastBootUpTime":"20210605233519.500000+000"}
 {"CreationTime":"2021-06-12T23:35:18Z","PhysicalProcessorCount":2,"CoresPerPhysicalProcessor":1,"LogicalProcessorsPerPhysicalProcessor":2,"MaximumMemory":3145728000,"OSMajor":10,"OSMinor":0,"OSBuildNumber":17763,"OSPlatformId":2,"ServicePackMajor":0,"ServicePackMinor":0,"OSSuiteMask":400,"OSProductType":3,"OSCurrentTimeZone":0,"OSDaylightInEffect":false,"SystemManufacturer":"VMware, Inc.","SystemProductName":"VMware7,1","SystemSMBIOSUUID":"49704D56-60F8-0A10-1C09-0156A066C2C3","SystemSerialNumber":"VMware-56 4d 70 49 f8 60 10 0a-1c 09 01 56 a0 66 c2 c3","SystemDNSHostName":"DC-1","SystemDomainName":"WORKGROUP","OSSerialNumber":"00431-20000-00000-AA261","OSCountryCode":"1","OSLastBootUpTime":"20210612233304.500000+000"}

diff --git a/fixtures/WebCacheV01.dat.golden b/fixtures/WebCacheV01.dat.golden
@@ -1,6 +1,4 @@
 {"ContainerId":1,"SetId":0,"Flags":68,"Size":0,"Limit":1024,"LastScavengeTime":0,"EntryMaxAge":0,"LastAccessTime":133370576566552287,"Name":"History","PartitionId":"M","Directory":"C:\\Users\\Administrator\\AppData\\Local\\Microsoft\\Windows\\History\\History.IE5\\"}
 {"ContainerId":2,"SetId":0,"Flags":64,"Size":0,"Limit":1024,"LastScavengeTime":0,"EntryMaxAge":0,"LastAccessTime":133370576566722799,"Name":"MSHist012023082020230821","PartitionId":"M","Directory":"C:\\Users\\Administrator\\AppData\\Local\\Microsoft\\Windows\\History\\History.IE5\\MSHist012023082020230821\\"}
-{"ContainerId":2155814921,"SetId":134283264,"Flags":16791936,"Size":0,"Limit":1140850688,"LastScavengeTime":0,"EntryMaxAge":4,"LastAccessTime":0,"Name":""}
 {"EntryId":2,"ContainerId":2,"CacheId":0,"UrlHash":3019452809937611611,"SecureDirectory":0,"FileSize":0,"Type":2097156,"Flags":4,"AccessCount":1,"SyncTime":133370576566752849,"CreationTime":0,"ExpiryTime":0,"ModifiedTime":133370324566642496,"AccessedTime":133370576566752849,"PostCheckTime":0,"SyncCount":0,"ExemptionDelta":86400,"Url":":2023082020230821: Administrator@:Host: This PC"}
 {"EntryId":1,"ContainerId":2,"CacheId":0,"UrlHash":8670262967669071927,"SecureDirectory":0,"FileSize":0,"Type":2097156,"Flags":4,"AccessCount":1,"SyncTime":133370576566722799,"CreationTime":0,"ExpiryTime":133393040566647726,"ModifiedTime":133370324566642496,"AccessedTime":133370576566722799,"PostCheckTime":0,"SyncCount":0,"ExemptionDelta":86400,"Url":":2023082020230821: Administrator@file:///C:/מדריך/test.html"}
-{"EntryId":7582925233825194002,"ContainerId":551890165795,"CacheId":33635233236516864,"UrlHash":1,"SecureDirectory":2,"FileSize":0,"Type":0,"Flags":1763942455,"AccessCount":2018702907,"SyncTime":0,"CreationTime":9007216434610176,"ExpiryTime":4294967300,"ModifiedTime":133370576566722799,"AccessedTime":0,"PostCheckTime":133393040566647726,"SyncCount":2204077888,"ExemptionDelta":31052698}