-
Notifications
You must be signed in to change notification settings - Fork 12
Creating Compound Metrics and Expanding our checkpointers (2/5) #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d metrics file, expanding the checkpointers to make best metric available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…d metrics file, expanding the checkpointers to make best metric available
…e/FL4Health into dbe/creating_metrics_base
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
+ Coverage 75.84% 75.95% +0.10%
==========================================
Files 144 145 +1
Lines 8782 8809 +27
==========================================
+ Hits 6661 6691 +30
+ Misses 2121 2118 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PR Type
Refactor
Short Description
This PR does a few fairly small things.
compound_metrics.py
, which will hold metrics that wrap metrics (hence the compound).EMAMetric
, which will be added in the next PR, is another example of this kind of object.Tests Added
Most of the changes are refactors, but I added extensive testing of the
TransformsMetric
class, as we didn't seem to have any prior to this.