[IMP] http_routing: Avoid returning verbose errors #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hugho-ad @moylop260 @xmglord Could you please take a look? |
|
could you share a video/screenshots about the output to the user and output in the logger, please? |
Returning verbose errors presents a vulnerability to subsequent attacks by sharing information that could be used to find and exploit vulnerabilites. To fix this, the traceback sent to the template for the error page now displays a hash instead. This hash will match a hash that will accompany the error within the log, so that errors raised can still be debugged
VEscaname
force-pushed
the
15.0-avoid_verbose_errors-vescaname
branch
from
d21ba24
to
7dbf25b
Compare
Sure thing. Here is the link to the video. I also added the requested screenshots to the PR description |
|
I'm curious what Odoo thinks about |
|
@moylop260 as explained by my collegue by email, we don’t really consider this as an issue as the code is open source anyway. At least in term of security, might be different for a UX point of view but it’s hidden for visitors anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Returning verbose errors presents a vulnerability to subsequent attacks by sharing information that could be used to find and exploit vulnerabilites.
Current behavior before PR:
Errors can be displayed in an error page with a full traceback for debugging
Desired behavior after PR is merged:
The traceback sent to the template for the error page now displays a hash instead. This hash will match a hash that will accompany the error within the log, so that errors raised can still be debugged
Related Task T#77665