Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhace search bars #516

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

Saksham2k3s
Copy link
Contributor

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

This update enhances the search functionality within the menu page of the application, enabling users to efficiently search for dishes across breakfast, lunch, and dinner categories. The previous implementation had limitations in filtering and displaying relevant search results, which has been addressed in this update.

Fixes #510

Type of change

Please mark with an X the type that applies:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor code
  • Documentation update
  • Other (mentioned in the issue number)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce them. Please also list any relevant details for your test configuration.

Test A: Describe here

  • Search Functionality: Tested the search bar by entering various search terms and verified that the correct results were displayed. Checked behavior with empty and non-existent search terms.
  • Category Selection: Ensured that switching between categories (breakfast, lunch, dinner) updates the displayed items appropriately.
  • Canteen Data: Verified that the canteen's social media links and email display correctly and link out as expected.

Test B: Describe here (if required)

Screenshots and Videos

Please provide screenshots and videos of the changes you made.

search

Checklist

Please mark with an X the items that apply:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Aug 8, 2024

@Saksham2k3s is attempting to deploy a commit to the vansh69's projects Team on Vercel.

A member of the Team first needs to authorize it.

@hustlerZzZ hustlerZzZ added gssoc This label is attached to the issues related to Gssoc'24 level2 labels Aug 9, 2024
@hustlerZzZ hustlerZzZ merged commit fe05f11 into VanshKing30:main Aug 9, 2024
1 of 2 checks passed
Copy link

github-actions bot commented Aug 9, 2024

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This label is attached to the issues related to Gssoc'24 level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Enhancement of the website's search bars
2 participants