Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat:Error In Seeing Menu From User End #314 #322

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

nishant0708
Copy link
Contributor

@nishant0708 nishant0708 commented Jun 15, 2024

Feat:Error In Seeing Menu From User End #314

In This Pr i have Solved

Foodies-web-erroes.mp4

1)All these Bugs which were present In Main Branch

2) Removed HardCoded Url Values
3) Added env example file so new user can easily setup project in correct way

4) fixed image on menu card error (All the images were coming from unsplash and fixed issue when user have its own image)

Screenshot 2024-06-16 024933

Here if user has its own Image then It will be showned inplace on random unsplashed Image

image

5) And Fixed Menu Not Showing Issue

6) Duplicate Code present in Signup and SignIn page
7) Fixed Navbar pages error

Fixes # (issue)

Type of change

Please give a X on it which is applicable

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Refactor Code
  • A documentation update
  • Others(mentioned in the issue number)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A Describe here

Test B Describe here (if Requred)

Screenshorts and Vedios:

give screenshorts and vedio of the changes you made

Checklist:

give a X on it which is applicable

  • [x ] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes
  • [ x] Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Jun 15, 2024

@nishant0708 is attempting to deploy a commit to the vansh69's projects Team on Vercel.

A member of the Team first needs to authorize it.

@nishant0708
Copy link
Contributor Author

nishant0708 commented Jun 15, 2024

hey @hustlerZzZ In This I have Solved Multiple(7-8 ) Issues in Project please assign it level accordingly

@hustlerZzZ
Copy link
Collaborator

hey @hustlerZzZ In This I have Solved Multiple(7-8 ) Issues in Project please assign it level accordingly

Can you mention them all

@hustlerZzZ hustlerZzZ added gssoc This label is attached to the issues related to Gssoc'24 level3 labels Jun 16, 2024
@nishant0708
Copy link
Contributor Author

nishant0708 commented Jun 16, 2024

hey @hustlerZzZ In This I have Solved Multiple(7-8 ) Issues in Project please assign it level accordingly

Can you mention them all

Hey @hustlerZzZ have mentioned them in pr description And have Fixed All conflicts You Can merge It Now And issue #325. IS Also Fixed here

@nishant0708
Copy link
Contributor Author

Hey @hustlerZzZ Can you please Merge these branch because Without Changes present in this branch i can't start working on my other issue #320 #293 as it will create merge conflicts if started by solving them temporarily .I Hope you Get It ... as all of them are Linked Issues.

@hustlerZzZ hustlerZzZ merged commit c025c37 into VanshKing30:main Jun 17, 2024
0 of 2 checks passed
Copy link

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This label is attached to the issues related to Gssoc'24 level3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants