Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat:In FoodList we Can add option to Edit FoodItem Name for Canteen #310 #313

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

nishant0708
Copy link
Contributor

-Added Backend For Editing Menu Item
-Added modal
-Updated FoodList Component

Fixes # 310

Type of change

Please give a X on it which is applicable

  • Bug fix (non-breaking change which fixes an issue)
  • [X ] New feature (non-breaking change which adds functionality)
  • Refactor Code
  • A documentation update
  • Others(mentioned in the issue number)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

-Add Items And then click on edit icon

Screenshorts and Vedios:

foodies-item-update.mp4

Checklist:

give a X on it which is applicable

  • [x ] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes
  • [ x] Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Jun 12, 2024

@nishant0708 is attempting to deploy a commit to the vansh69's projects Team on Vercel.

A member of the Team first needs to authorize it.

@nishant0708
Copy link
Contributor Author

nishant0708 commented Jun 13, 2024

Hey @hustlerZzZ @mrigankabrahma @VanshKing30 please CHeck this pr and let me know any changes if any

@hustlerZzZ hustlerZzZ added gssoc This label is attached to the issues related to Gssoc'24 level1 labels Jun 15, 2024
Copy link
Collaborator

@hustlerZzZ hustlerZzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work buddy!

@hustlerZzZ hustlerZzZ merged commit 0652d4c into VanshKing30:main Jun 15, 2024
1 of 3 checks passed
Copy link

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

@nishant0708
Copy link
Contributor Author

Hey @hustlerZzZ please assign it level 2 because it required me making backend as well so I think it's not of level 1

@hustlerZzZ hustlerZzZ added level2 and removed level1 labels Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This label is attached to the issues related to Gssoc'24 level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants