Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]:"Confirm Password" field added in signup page #308

Merged
merged 4 commits into from
Jun 15, 2024
Merged

[Bug]:"Confirm Password" field added in signup page #308

merged 4 commits into from
Jun 15, 2024

Conversation

chandannekya
Copy link

@chandannekya chandannekya commented Jun 12, 2024

This pull request adds a "Confirm Password" field to the signup page to enhance user experience by ensuring that users enter their desired password correctly during registration. Additionally, it includes backend validation to ensure the password and confirm password fields match before creating a new account. This enhancement will reduce user errors and improve overall security.

Fixes #287

Type of change

1.Frontend Changes:

Signup Component:
Added a new input field for "Confirm Password" in the signup form.
Implemented a visibility toggle for the confirm password field similar to the password field.
2.Backend Changes:
Auth Controller:
Added validation logic to check if the password and confirm password fields match before proceeding with account creation.
If the passwords do not match, the server responds with an appropriate error message.

Please give a X on it which is applicable

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor Code
  • A documentation update
  • Others(mentioned in the issue number)

How Has This Been Tested?

Manually tested the signup form to ensure the confirm password field functions correctly.
Verified that the form does not submit if the passwords do not match and an error message is shown.

Test A Describe here

Screenshorts and Vedios:

freecompress-foodwebconfirmpassword.mp4

Checklist:

give a X on it which is applicable

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Jun 12, 2024

Someone is attempting to deploy a commit to the vansh69's projects Team on Vercel.

A member of the Team first needs to authorize it.

@hustlerZzZ hustlerZzZ added gssoc This label is attached to the issues related to Gssoc'24 level3 labels Jun 15, 2024
Copy link
Collaborator

@hustlerZzZ hustlerZzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@hustlerZzZ hustlerZzZ merged commit ecb3718 into VanshKing30:main Jun 15, 2024
1 check failed
Copy link

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This label is attached to the issues related to Gssoc'24 level3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG:Add "Confirm Password" Field to Signup Page
2 participants