Feature/g UI ld 1306 remove ip allow list #207
Conversation
Minimum allowed line rate is |
| with StringIO() as stream: | ||
| yaml.explicit_start = explicit_start |
There was a problem hiding this comment.
It adds the --- at the start of yaml files so that the commit hook doesn't complain every time we (I) run the Upgraders.
src/mpyl/projects/versioning.py
Outdated
| ProjectUpgraderTwo(project_file), | ||
| ProjectUpgraderThree(), | ||
| ] | ||
| is_traefik_file = "-traefik" in project_file.name |
There was a problem hiding this comment.
Adding these if/else conditions in the code makes this setup much harder to understand and (most importantly) to extend, so I created this small PR with a proposal of a different way to make this work. Let me know what you think! 🙂
There was a problem hiding this comment.
Hehe I like how you usually precisely find the problems in my code that I was also discussing with myself while writing it. Basically I couldn't see an easy way to do it better and I was in a bit of a rush 😉 plus I told myself we won't have to support other files besides these 2 types.
I'll for sure take a look tomorrow!
…D-1306-remove-ipAllowList
No description provided.