Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: create a Certificate chart for pr deployments (#198)" #206

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

Jorg88
Copy link

@Jorg88 Jorg88 commented Feb 26, 2025

This reverts commit 30bac4f, reversing changes made to 135846a.

@Jorg88 Jorg88 requested a review from ptab February 26, 2025 14:44
@Jorg88 Jorg88 requested a review from a team as a code owner February 26, 2025 14:44
Copy link

Code Coverage

Package Line Rate Health
src.mpyl 85%
src.mpyl.cli 63%
src.mpyl.plan 100%
src.mpyl.projects 73%
src.mpyl.steps 92%
src.mpyl.steps.deploy 80%
src.mpyl.steps.deploy.k8s 95%
src.mpyl.steps.deploy.k8s.resources 98%
src.mpyl.utilities 92%
src.mpyl.utilities.dagster 72%
src.mpyl.utilities.docker 82%
src.mpyl.utilities.helm 100%
src.mpyl.utilities.http_client 85%
src.mpyl.utilities.logging 78%
src.mpyl.utilities.pyaml_env 100%
src.mpyl.utilities.repo 97%
src.mpyl.utilities.subprocess 76%
src.mpyl.utilities.yaml 100%
Summary 86% (1918 / 2237)

Minimum allowed line rate is 79%

Copy link

@ptab ptab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll put it back soon 💪

@Jorg88 Jorg88 merged commit d5f37a8 into main Feb 26, 2025
9 checks passed
@Jorg88 Jorg88 deleted the feature/GUILD-1290-certificate-charts-revert branch February 26, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants