Use the dxredist X3DAudio/XAPOFX DLLs for 64-bit #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. Can you list some games this helps? |
|
Bethesda games (Skyrim, FO4), UE3/UE4 games (MOTHERGUNSHIP, A Hat in Time, KF2, Soul Calibur 6), Rebellion games (Strange Brigade, Sniper Elite), id Tech 5+ games (RAGE, WolfTNO), Warframe, Hellblade, basically anything that's not using XAudio2 via Wwise. |
|
Cool, thanks. Will merge. |
|
This was merged as d0d3899 in 4.2-4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
!_WIN64guards for X3DAudio's and XAPOFX'sDLL_WINE_PREATTACHcases for Proton.The main reason we prefer the builtins for 64-bit is because XAudio2 has some strange behavior on Win64 for reasons unknown. However, that only applies to XAudio2_*.dll; the other XAudio2 libraries should be perfectly safe to use. We still use FACT for XACT3 support since FACT works best with FAudio, but we can get some pretty good accuracy improvements from using Microsoft's X3DAudio (accuracy in F3DAudio still isn't great) and get all the proper effects from the official XAPOFX library (which we don't have implemented at all right now).