Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13: move UpdateAdaptiveQuality() to LateUpdate. #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #13: move UpdateAdaptiveQuality() to LateUpdate. #17

wants to merge 1 commit into from

Conversation

TrebuhD
Copy link

@TrebuhD TrebuhD commented Oct 19, 2016

Fix the adaptive quality screen flicker bug by moving UpdateAdaptiveQuality() from OnPreCull() to LateUpdate() in ValveCamera.cs, as suggested by @Selkcip.

Fix the adaptive quality screen flicker bug by moving
UpdateAdaptiveQuality() from OnPreCull() to LateUpdate().
@SpencerMalone
Copy link

I still get a "jump" anytime it changes quality. Is that to be expected? Seems like not.

@SpencerMalone
Copy link

I guess it's not every time it changes quality, but there is certainly an increase in the lurches that I get.

@Selkcip
Copy link

Selkcip commented Oct 29, 2016

Is it hitching or are you seeing a skewed frame? This won't fix occasional hitching, but does fix a serious bug where a single, very obvious, frame would be rendered with the wrong viewport dimensions making things unplayable.

@SpencerMalone
Copy link

It was hitching, as it turns out. Not sure if it was reimporting the assets or bumping up my unity version, but one of the two solved it. I think I was getting hitching+the frame thing before, and this definitely fixed the frame badness, but left the hitching (because it was my fault 😿 ). Anyways, this LGTM!

@mikejichaow
Copy link

it does fixed flickering by moving UpdateAdaptiveQuality(); to lateupdate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants