Patch for includes v1.23.7 #1676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tnx bro! |
|
why? greetings EDIT: is now upsteamed? |
|
@sl1pkn07 I believe the current commit 01c6ba7 is buildable without issues and my patch could only confuse people. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an updated variant of the #1524.
It seems another error creeped in in the new release, one enum error code was removed from the header, but left in
./vrcommon/hmderrors_public.cpp. I changed that to the new enum which has the same number as the removed one.It seems however that the function
GetEnglishStringForHmdErrorin the same file is also not fully up to date for the new (and not so new) enums. Is this function supposed to cover all defined enums? If yes, quite a few seems to be missing.One may wonder if someone forgot to export a new version of this file to the GitHub repo, because even locally Valve would not be able to build the sources as they are.